Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

evm: go-ethereum related updates #469

Merged
merged 11 commits into from
Aug 25, 2021
Merged

evm: go-ethereum related updates #469

merged 11 commits into from
Aug 25, 2021

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added C:Proto protobuf files (*.pb.go) Type: Docs Improvements or additions to documentation labels Aug 21, 2021
@orijbot
Copy link

orijbot commented Aug 23, 2021

@github-actions github-actions bot added C:CLI C:Types common types, interfaces and functions from /types Type: Build codebase build process Type: CI continuous integration labels Aug 25, 2021
@github-actions github-actions bot removed the Type: CI continuous integration label Aug 25, 2021
@fedekunze fedekunze marked this pull request as ready for review August 25, 2021 14:26
@fedekunze fedekunze enabled auto-merge (squash) August 25, 2021 14:38
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #469 (1b58534) into main (f732774) will decrease coverage by 5.84%.
The diff coverage is 13.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   53.41%   47.56%   -5.85%     
==========================================
  Files          16       57      +41     
  Lines        1715     5466    +3751     
==========================================
+ Hits          916     2600    +1684     
- Misses        764     2749    +1985     
- Partials       35      117      +82     
Impacted Files Coverage Δ
x/evm/keeper/abci.go 13.33% <0.00%> (ø)
x/evm/keeper/eip1559.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 70.40% <0.00%> (ø)
x/evm/keeper/keeper.go 61.80% <0.00%> (ø)
x/evm/types/dynamic_fee_tx.go 0.00% <ø> (ø)
x/evm/types/key.go 0.00% <ø> (ø)
x/evm/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/evm/types/chain_config.go 97.45% <70.00%> (ø)
x/evm/types/params.go 64.86% <75.00%> (ø)
x/evm/keeper/state_transition.go 58.82% <100.00%> (ø)
... and 41 more

@fedekunze fedekunze merged commit 1ad9b4c into main Aug 25, 2021
@fedekunze fedekunze deleted the geth-updates branch August 25, 2021 14:45
parentGasUsed := k.GetBlockGasUsed(ctx)

gasLimit := new(big.Int).SetUint64(math.MaxUint64)
if consParams != nil && consParams.Block.MaxGas > -1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

origin one @yihuang

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C:CLI C:Proto protobuf files (*.pb.go) C:Types common types, interfaces and functions from /types Type: Build codebase build process Type: Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants